-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix null ptdfSum in evaluator, relative margin case #1264
Merged
phiedw
merged 14 commits into
main
from
fix/issue-when-open-branch-as-cnec-post-contingency
Feb 17, 2025
Merged
Fix null ptdfSum in evaluator, relative margin case #1264
phiedw
merged 14 commits into
main
from
fix/issue-when-open-branch-as-cnec-post-contingency
Feb 17, 2025
+370
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…post contingency Signed-off-by: MURGEY Sebastien <[email protected]>
Signed-off-by: Godelaine de Montmorillon <[email protected]>
Signed-off-by: Godelaine de Montmorillon <[email protected]>
phiedw
requested changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls fill in the PR description
...src/test/java/com/powsybl/openrao/searchtreerao/commons/AbsolutePtdfSumsComputationTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Godelaine de Montmorillon <[email protected]>
Signed-off-by: Godelaine de Montmorillon <[email protected]>
Signed-off-by: Philippe Edwards <[email protected]>
Signed-off-by: Philippe Edwards <[email protected]>
phiedw
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix : when ptdf sum =0 with relative margin computation, getRelativeMargin returned NaN. This happened for instance when a cnec was open in the network. Now, parameter ptdf sum lower bound is added to ptdf sum, similarly to what is done in the relative margin filler.